Kubo v0.23.0 feedback

[galargh]

This issue is going to capture feedback from the v0.23.0 release

[galargh]

The PRs created in Kubo should contain [skip changelog] in the title, or it should have a skip-changelog label. See https://filecoinproject.slack.com/archives/C04M8232QRW/p1695727228179229

[Jorropo]

It gets caught in an infinite loop when trying to set MATRIX_PASSWORD without it being set in .env:

MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token:: 
MATRIX_TOKEN is not set. If you don't have a token, you can leave it blank and use a password instead. Please enter the token::

AFAIT what happen is that the utils package is wrote to retry if the input is empty, but then it can't check for an empty input. I did that as a workaround:

> git diff
diff --git a/matrix/matrix.go b/matrix/matrix.go
index 52e83bc..615212d 100644
--- a/matrix/matrix.go
+++ b/matrix/matrix.go
@@ -16,7 +16,8 @@ type Client struct {
 func NewClient() (*Client, error) {
        url := util.GetenvPrompt("MATRIX_URL")
        user := util.GetenvPrompt("MATRIX_USER")
-       token := util.GetenvPromptSecret("MATRIX_TOKEN", "If you don't have a token, you can leave it blank and use a password instead. Please enter the token:")
+       var token string
+       //token := util.GetenvPromptSecret("MATRIX_TOKEN", "If you don't have a token, you can leave it blank and use a password instead. Please enter the token:")
        password := util.GetenvPromptSecret("MATRIX_PASSWORD", "If you don't have a password, you can leave it blank and use a token instead. Please enter the password:")
        if token == "" && password == "" {
                return nil, fmt.Errorf("MATRIX_TOKEN nor MATRIX_PASSWORD are set")

[galargh]

I made the prompt ask only once from now on: https://github.com/ipfs/kuboreleaser/commit/909bc19e6e78520a923cad8196c1a65dac7493ac And I included skip changelog direction in kubo PRs: https://github.com/ipfs/kuboreleaser/commit/746f8b5ed1742f96f24bed54d7b505e8123183ba