search

ipfs / npm-kubo

Install Kubo (go-ipfs) from NPM
https://www.npmjs.com/package/kubo
MIT License
42 stars 30 forks source link

release 0.4.x #10

Closed harlantwood closed 7 years ago

jbenet commented 8 years ago

wait, why isn't this happening!? it's part of the go-ipfs release checklist https://github.com/ipfs/go-ipfs/blob/master/docs/releases.md

cc @whyrusleeping @Kubuxu ??

whyrusleeping commented 8 years ago

It appears this doesnt happen because this package relies on gobuilder

whyrusleeping commented 8 years ago

@diasdavid mentioned there was a different npm package for getting the go-ipfs daemon in javascript.

daviddias commented 8 years ago

js-ipfsd-ctl relies on go-ipfs-dep now, it is a simpler version of npm-go-ipfs that works with dist.ipfs.io instead of go-builder.

For now it is just 0.4.1, as we can't update to 0.4.2 due to a bug in 0.4.2.

@jgantunes is doing a really awesome work of upgrading js-ipfsd-ctl to use binwrapper, that will solve the Arch problem https://github.com/ipfs/js-ipfsd-ctl/pull/89

I'll go ahead an update this module description to point to go-ipfs-dep.

harlantwood commented 8 years ago

@diasdavid if I read this correctly, I understand that:

  1. this module ( https://github.com/ipfs/npm-go-ipfs ) is deprecated
  2. https://github.com/diasdavid/go-ipfs-dep is the replacement

Correct?

paul90 commented 8 years ago

Looks as if this is still not resolved.

If this module is deprecated then it needs a deprecate message adding in npm to point to the correct place. Also the readme there needs updating to install the correct npm package, and not this one.

jbenet commented 7 years ago

guys, come on! people depend on this module-- including me. it wasted 20min of my time to realize that this was go-ipfs 0.3x being installed...

jbenet commented 7 years ago

this module should not be deprecated-- why do people think it is? the goal of this module is to enable this:

> npm install go-ipfs
> node_modules/.bin/ipfs version

and this

> npm install -g go-ipfs
> ipfs version

as the readme says, to install go-ipfs. it should be using dist.ipfs.io

jbenet commented 7 years ago

I'm on this, fixing it.

jbenet commented 7 years ago

Okay, fixed. I published:

0.4.0 as 0.4.0-hacky2
0.4.1 as 0.4.1-hacky2
0.4.2 as 0.4.2-npmfix2
0.4.3 as 0.4.3-npmfix1
0.4.4 as 0.4.4

sorry for the silly version suffixes.

> npm view go-ipfs versions

[ '0.2.3',
  '0.2.4',
  '0.2.5',
  '0.2.6',
  '0.2.7',
  '0.2.8',
  '0.2.9',
  '0.2.10',
  '0.2.11',
  '0.3.0',
  '0.3.2-2',
  '0.3.2',
  '0.3.4-2',
  '0.3.4-3',
  '0.3.4',
  '0.3.5-2',
  '0.3.5',
  '0.3.6-1',
  '0.3.6-2',
  '0.3.6',
  '0.3.7-2',
  '0.3.7-3',
  '0.3.7-fix',
  '0.3.7',
  '0.3.8-1',
  '0.3.8',
  '0.3.9',
  '0.3.10',
  '0.3.11',
  '0.4.0-hacky2',
  '0.4.1-hacky2',
  '0.4.2-npmfix2',
  '0.4.3-npmfix1',
  '0.4.4' ]
harlantwood commented 7 years ago

Awesome, thanks. For the record, this is exactly what I want too: an executable that can be run from the shell, but managed via NPM.

harlantwood commented 7 years ago

wait, why isn't this happening!? it's part of the go-ipfs release checklist https://github.com/ipfs/go-ipfs/blob/master/docs/releases.md

Not sure where to properly file this, but maybe there could be a check on CI that would fail if all of the steps for a given release were not completed (at least those, like this one, that are easy to check automatically).