ipfs / npm-kubo

Install Kubo (go-ipfs) from NPM
https://www.npmjs.com/package/kubo
MIT License
41 stars 30 forks source link

Simplify this module with binwrap #24

Closed daviddias closed 3 years ago

daviddias commented 5 years ago

This PR is an attempt at simplifying this module drastically. It uses binwrap, a npm module that pretty much does all the dark magic that this npm-go-ipfs and https://github.com/ipfs/npm-go-ipfs-dep were doing.

My goal is to move from having two modules npm-go-ipfs and npm-go-ipfs-dep to only have one.

To complete this PR:

Post merge and release

achingbrain commented 4 years ago

The tests and the automation is in place but it'd still be great to delete half the code from this module by making this change.

lidel commented 3 years ago

Closing as stale: this most likely needs to be rebased/rewritten to account for hash verification and cache included in https://github.com/ipfs/npm-go-ipfs/pull/32