ipfs / protons

Protocol Buffers for Node.js and the browser without eval
Other
32 stars 23 forks source link

Generated TypeScript files cause compilation errors due to unused variables #130

Open danisharora099 opened 8 months ago

danisharora099 commented 8 months ago

When using the protons library to generate TypeScript files from .proto files, the generated code contains unused variables, specifically the opts parameter in certain functions. This causes compilation errors when running TypeScript with strict checks enabled.

Steps to reproduce:

Expected behavior:

The generated TypeScript files should not cause any compilation errors related to unused variables.

Actual behavior:

The generated TypeScript files contain unused opts parameters in certain functions, leading to compilation errors when strict checks are enabled.

Example error:

src/generated/example.ts:40:29 - error TS6133: 'opts' is declared but its value is never read.
40 }, (reader, length, opts = {}) => {
                       ~~~~

Workarounds:

Proposed Solution

Update the protons library to generate TypeScript code that doesn't include unused variables.

Please let me know if you need any additional information or if there's anything else I can do to assist in resolving this issue. Thank you for your attention and efforts in maintaining the protons library.

cc @achingbrain

wemeetagain commented 5 months ago

This is definitely not ideal, would defer to achingbrain on whether this is worth pursuing.

Definitely recommend not using typescript for linting, though. Rather use the linter to apply all linter rules.