search

ipfs / protons

Protocol Buffers for Node.js and the browser without eval
Other
32 stars 23 forks source link

Doesn't respect optional fields when using proto2 syntax #34

Closed mpetrunic closed 1 year ago

mpetrunic commented 2 years ago

Example: https://github.com/libp2p/js-libp2p-daemon/pull/94

mpetrunic commented 2 years ago

I don't think this is fixable unless there is a way to distinguish proto2 vs proto3 sytax here: https://github.com/ipfs/protons/blob/master/packages/protons/src/index.ts#L121 cc @achingbrain

BigLep commented 2 years ago

2022-06-07 conversation: we're going to throw an error if we see proto2 syntax.

MarcoPolo commented 2 years ago

2022-06-07 conversation: we're going to throw an error if we see proto2 syntax.

I don't think this is a viable solution. Right now, we have a lot of proto2 definitions.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version protons-v6.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: