search

ipfs / protons

Protocol Buffers for Node.js and the browser without eval
Other
32 stars 23 forks source link

fix: use CLI flag `--output` #46

Closed D4nte closed 2 years ago

D4nte commented 2 years ago

The flag was not used to determine the output dir.

Now, if the flag is set, it is used as output dir, if not set, directory containing the proto file is used.

D4nte commented 2 years ago

Do not merge, I noticed an issue with GLOBs.

D4nte commented 2 years ago

Do not merge, I noticed an issue with GLOBs.

Irrelevant, glob expressions are not supported in the first place.

mishmosh commented 2 years ago

@achingbrain The author (:wave: @D4nte) pinged us in the #devrel channel to ask the best way to get this reviewed. Can you review this, or loop in the right person to do so?

achingbrain commented 2 years ago

Thanks!

github-actions[bot] commented 2 years ago

:tada: This PR is included in version protons-v3.0.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: