search

ipfs / protons

Protocol Buffers for Node.js and the browser without eval
Other
32 stars 23 forks source link

`uint8arraylist` missing as peer dependency #59

Closed fryorcraken closed 2 years ago

fryorcraken commented 2 years ago

Generated files contains the following line:

import type { Uint8ArrayList } from "uint8arraylist";

Depending on how npm manages the dependencies, that may lead to issues such as:

src/proto/store_v2beta4.ts:271:5 - error TS2322: Type 'import("/home/fryorcraken/src/status-im/js-waku/node_modules/protons-runtime/node_modules/uint8arraylist/dist/src/index").Uint8ArrayList' is not assignable to type 'import("/home/fryorcraken/src/status-im/js-waku/node_modules/uint8arraylist/dist/src/index").Uint8ArrayList'.

271     return encodeMessage(obj, WakuMessage.codec());

Proposal: declare the right uint8arraylist as a peer dependency of protons-runtime.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version protons-runtime-v3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: