search

ipfs / protons

Protocol Buffers for Node.js and the browser without eval
Other
32 stars 23 forks source link

fix!: adhere more closely to the language guide for proto3 default values #66

Closed achingbrain closed 2 years ago

achingbrain commented 2 years ago

Only write singular fields when they are non-default values (unless in repeated fields). Always write optional values even when they are non-default values.

Updates test suite to compare generated bytes to protobuf.js to ensure compatibility.

Also adds a README section on differences between protons and protobuf.js.

BREAKING CHANGE: ts definitions will need to be generated from .proto files - singular message fields have become optional as message fields are always optional in proto3

fixes #43

github-actions[bot] commented 2 years ago

:tada: This PR is included in version protons-runtime-v4.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version protons-v6.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: