ux: unable to exit config editor on inbrowser.tld

ipfs / service-worker-gateway

[WIP EXPERIMENT] IPFS Gateway implemented in Service Worker

https://inbrowser.dev

Other

17 stars 8 forks source link

ux: unable to exit config editor on inbrowser.tld #289

Open lidel opened 3 weeks ago

lidel commented 3 weeks ago

Problem

If I open https://inbrowser.dev and click on config editor:

There is no way to close editor and go back to the main screen where i can enter the content path, i am stuck in config editor and have to manually edit URL in address bar:

Fix ideas

make clickin "Save config" collapse config when embedded on Iframe and remove /#/ipfs-sw-config from URL if not in iframe (on main domain)
Or keep "Save Config" as-is and add dedicated "Close" button that does the above.

SgtPooki commented 2 weeks ago

make clicking "Save config" collapse config when embedded on Iframe and remove /#/ipfs-sw-config from URL if not in iframe (on main domain)

this is supposed to already exist. Will look into this now.

SgtPooki commented 2 weeks ago

~~"save config" does close config edit screen on inbrowser.dev and local.~~

Actually, after clicking "reset config" it doesn't... interesting.

SgtPooki commented 2 weeks ago

Actually, after clicking "reset config" it doesn't... interesting.

After clearing all storage in the browser, and having a valid config, the reload button works fine, I can't reproduce on inbrowser.dev when using the settings gear icon directly from the homepage, and clicking "save config" to close it.

clicking "reset config" and then "save config" also continues to work after I cleared browser settings

SgtPooki commented 2 weeks ago

and now I can reproduce locally with the code from https://github.com/ipfs/service-worker-gateway/pull/293.... I need to figure out what is going on