Open lidel opened 1 week ago
@lidel I'm concerned about how the large config would look on the main page.. it's going to be quite large. I think just rendering the config fully on the main page is more clunky than hiding it behind a toggle. Plus, the config page is required for the interstitial page.
Also, I don't think this would improve e2e testing at all, but maybe I'm missing something.
I can throw something together for this and see how it looks
Let's give it a try:
We no longer show config on interstitial since https://github.com/ipfs/service-worker-gateway/pull/319, config only shows on main page.
just a FYI.. we do load/render the config page, even if it's not actually visible. we have to in order to get the IDB values from the database on the root origin in order to set on the subdomain origin
Configuration toggle no longer serves a purpose, we don't have it on subdomains and it makes UX on main page bit clunky (https://github.com/ipfs/service-worker-gateway/issues/289).
Proposal
Inline configuration on the main landing page. It will make it easier for users of this tech demo to see what is possible, and also simplify the way we do E2E and manual tests.