bug: config page message posting broken

ipfs / service-worker-gateway

IPFS Gateway implemented in Service Worker

https://inbrowser.link

Other

27 stars 8 forks source link

bug: config page message posting broken #68

Closed SgtPooki closed 6 months ago

SgtPooki commented 8 months ago

from https://vitalik-eth.ipns.inbrowser.link without SW registered, rendering the redirect page with config iframe:

Uncaught (in promise) DOMException: Failed to execute 'postMessage' on 'Window': Invalid target origin 'undefined' in a call to 'postMessage'.

SgtPooki commented 8 months ago

I think this is due to the _redirects not including the ?origin= in the requested iframe URL. we need to update _redirects to include something like /config:splat /#/config:splat 302

SgtPooki commented 7 months ago

I don't think this is an issue any longer, and we have e2e tests for this. will confirm and close or update with note

SgtPooki commented 6 months ago

This issue no longer seems to occur. closing