ipikuka / remark-flexible-markers

Remark plugin to add custom mark element with customizable properties in markdown
MIT License
10 stars 0 forks source link

Highlight text with links in markdown notation #2

Closed felipebayres closed 6 months ago

felipebayres commented 1 year ago

I´m trying to highlight a text that containts a markdown link in it.

For example ==Google is [quietly ramping upits AI efforts](https://www.wired.com/story/meet-bard-googles-answer-to-chatgpt/) in response to==

But what really renders is just the string itself: image

is this plugin expected to work with links as well?

talatkuyuk commented 1 year ago

Thank you for reporting the issue. I will take care.

talatkuyuk commented 8 months ago

Hi @felipebayres,

remark-flexible-markers traces over the text nodes, and looks for == signs.

Main problem is: The markdown link at the example breaks up the connection between the leading and trailing signs (==)

==Google is [here](https://www.google.com) and always available==

Above markdown phrase consists 3 nodes of text: 1st text --> ==Google is 2nd text (the link has a text as well) --> here 3rd text --> and always available==

As you see none of the text nodes does not satisfy the marker format, ==text==

In order to make connection between the leading and trailing signs (==), due to the fact that there is a link that breaks up the connection between them, it requires too much effort for the implementation. I need community support for that.

But for now, you can try to put == signs at both sides of each text phrase like this:

==Google is ==[==here==](https://www.google.com)== and always available==

In addition, you can set some css style for mark elements inside an anchor in order to provide smooth marker view.

talatkuyuk commented 6 months ago

Fixed with version 1.2.0. See https://github.com/ipikuka/remark-flexible-markers/releases/tag/v1.2.0

Now you can highlight the links as requested by @felipebayres like below,

==Google is [AI efforts](https://www.wired.com/story/meet-bard-googles-answer-to-chatgpt/) to==