search

ipinfo / rust

IPinfo Rust library for IPinfo API (IP geolocation and other types of IP data)
https://ipinfo.io
Apache License 2.0
56 stars 14 forks source link

Inline all data files #42

Closed UmanShahzad closed 11 months ago

UmanShahzad commented 1 year ago

We have several files like eu.json, countries.json, continents.json and so on, which are loaded during initialization / startup of the client.

Instead of loading these as such, which has risks such as the asset not appearing in a production environment properly, and has a performance penalty during init of loading an on-disk file, we should inline the files into a static, in-memory map / dictionary or similar.

UmanShahzad commented 1 year ago

@talhahwahla FYI

UmanShahzad commented 11 months ago

@talhahwahla done right?

talhahwahla commented 11 months ago

yeah was resolved here: https://github.com/ipinfo/rust/pull/43