ipinfo / rust

IPinfo Rust library for IPinfo API (IP geolocation and other types of IP data)
https://ipinfo.io
Apache License 2.0
56 stars 14 forks source link

Batch improvements and fix total timeout #46

Closed Alextopher closed 11 months ago

Alextopher commented 11 months ago

In #45 I shared how I think the total timeout condition is not being applied correctly. This PR fixes this by adding another helper function.

While I was making this change I noticed some improvements that can be made to the logic of batch lookups.

This should be a completely transparent (semver patch) change.

Alextopher commented 11 months ago

There is still required discussion on how to handle errors for batched lookups. I believe this PR doesn't effect the status-quo in that regard and therefor could be merged without considering changes to the error type.

Alextopher commented 11 months ago

The tests seem to be failing because of missing secrets on your end.