search

ipitio / backage

Endpoint behind badges for GitHub Packages
https://ipitio.github.io/backage/
MIT License
18 stars 10 forks source link

fix: Use lowercasing for pulls #7

Closed kroese closed 5 months ago

kroese commented 5 months ago

The official Docker pulls badge display the pulls count with lower casing, for example:

3.1k pulls

This badge displays it in uppercasing:

3.1K pulls

When displaying them side-by-side this looks a bit weird, so maybe better to use lowercase here too.

It also display 1 digit less:

4.3k pulls

While this badge displays 2:

4.32K pulls

ipitio commented 5 months ago

This will be fixed by https://github.com/ipitio/ghcr-pulls/commit/b8b57302fdb852434830fb92185c3ab49a82d062 (line 41) in ~2 hours

kroese commented 5 months ago

The update didnt change the file?

ipitio commented 5 months ago

It did! You might have to clear GitHub data to see the updated badges immediately.

ipitio commented 5 months ago

Oh, well not that commit specifically. The next commit ran the script and made the actual change