search

ipjohnson / Grace.DependencyInjection.Extensions

Grace Extensions for ASP.Net Core
19 stars 7 forks source link

Multi-target .NET Standard 2.0, .NET Core App 3.1 and .NET 5.0 #27

Closed silkfire closed 4 years ago

silkfire commented 4 years ago

PR for issue #24

silkfire commented 4 years ago

The CI pipeline failed because the environment uses the old version of MSBuild (16.7.0) whereas .NET 5 requires v16.8.0.

ipjohnson commented 4 years ago

I looked at this and it's good but as you pointed the build pipeline doesn't support 16.8.0 yet. Looking at appveyor updates I think it will be the end of this month that they do a release. I can merge it in then.

silkfire commented 4 years ago

Hey Ian, that's totally fine with me. I appreciate that you took the time to look into this PR. 😊

ipjohnson commented 4 years ago

appveyor has updated their image and I'll pull this in before thanksgiving.

silkfire commented 4 years ago

Fantastic news :)

silkfire commented 3 years ago

@ipjohnson Will you be pushing a new release to NuGet soonish?

ipjohnson commented 3 years ago

@silkfire sorry forgot to update the ticket, I pushed an RC version to nuget for testing when I merged this.

silkfire commented 3 years ago

I did realize that yes. How long will it be in RC?

ipjohnson commented 3 years ago

released