search

ipjohnson / Grace.DependencyInjection.Extensions

Grace Extensions for ASP.Net Core
19 stars 7 forks source link

Upgrade .NET 5 target to .NET 6 #30

Closed silkfire closed 2 years ago

silkfire commented 2 years ago

Similar to https://github.com/ipjohnson/Grace.DependencyInjection.Extensions/pull/27, it'd be nice to upgrade the .NET 5 TFM to .NET 6 as the former will stop being supported in May 2022.

Also bumped a few of dependencies and removed some that already are implicitly referenced.

silkfire commented 2 years ago

AppVeyor is failing because it requires the .NET 6 SDK.

ipjohnson commented 2 years ago

I think if you update the last line of appveyor.yml' file to beVisual Studio 2022` I think the PR will build

silkfire commented 2 years ago

They've increased the number of unit tests in DependencyInjectionSpecificationTests from 73 to 84 in Microsoft.Extensions.DependencyInjection.Specification.Tests version 6.0.0 and five of them are failing.

image

ipjohnson commented 2 years ago

I'm going to merge this and then add the IServiceProviderIsService interface that is causing this failure.

ipjohnson commented 2 years ago

@Lex45x you upgraded the version to 5.0 are you ok with bumping it to 6.0 or do you want a target for 5.0 in addition to 6.0?

EOL for version 5.0 is May 2022 so I could see keeping it for a little while longer if you're specifically using it.

Lex45x commented 2 years ago

@ipjohnson, sorry for the delay. Was on a long vacation. Feel free to get rid of .Net 5.0.

ipjohnson commented 2 years ago

Ok this has been released to nuget