search

ipjohnson / Grace

Grace is a feature rich dependency injection container library
MIT License
336 stars 33 forks source link

Logo for the library #217

Closed silkfire closed 5 years ago

silkfire commented 5 years ago

Have you considered to add a logo to your library? If you want, I can come up with a few design ideas. Something that would aptly fit the name, of course :)

ipjohnson commented 5 years ago

I actually hadn’t, I’d definitely be interested in seeing your designs.

silkfire commented 5 years ago

Great, I'll come back to you in a few days with my suggestions. Any preference when it comes to colors, shapes or imagery to be used?

ipjohnson commented 5 years ago

Thanks that would be really cool. Maybe greens or blues?

silkfire commented 5 years ago

Here's a couple of designs I made in Illustrator. What do you think?

grace-1 grace-2 grace-3

ipjohnson commented 5 years ago

Those look nice, I think I'll go with the bottom one and see if I can get it in for the 7.0 release

silkfire commented 5 years ago

Wooooow, glad you found one you liked. Looking forward to seeing it live.

Would you like me to make a PR where I include it in an /img/ folder? I assume you know how to refer to it from the .nuspec?

If you want the colors adjusted just tell me and I'll fine tune them to your liking.

ipjohnson commented 5 years ago

Sure a PR would be great, could you possible do a couple size 256,128,64?

silkfire commented 5 years ago

See pull request at https://github.com/ipjohnson/Grace/pull/219

ipjohnson commented 5 years ago

Awesome, thanks!

ipjohnson commented 5 years ago

Looks great. I'm going to get it added into the other satellite packages and should be ready for release.

Thanks again!

silkfire commented 5 years ago

@ipjohnson My pleasure. This should give the package a wee bit of character :)

Btw, please make sure to edit the link to the SVG icon in the README.md from:

https://raw.githubusercontent.com/silkfire/Grace/e0415b74141fbc17c88cbec7dd978460b3c9300a/img/logo.svg?sanitize=true

to

https://raw.githubusercontent.com/ipjohnson/Grace/7c24bfa184bc4b984e64b9e8d2457200a64a0724/img/logo.svg?sanitize=true

As it was pointing to the image relative to my fork.