search

ipjohnson / Grace

Grace is a feature rich dependency injection container library
MIT License
336 stars 33 forks source link

Added net7. Fixed typos. Small refactorings. #304

Closed bogdandynamic closed 1 year ago

bogdandynamic commented 1 year ago

Added net7. Fixed typos in file naming and code. Changed empty array initializations.

silkfire commented 1 year ago

Adding .NET 7 as a target won't add any value beyond what .NET 6 already provides.

bogdandynamic commented 1 year ago

Adding .NET 7 as a target won't add any value beyond what .NET 6 already provides.

I agree with you.

The pull request consists mainly on fixing typos, and a little bit of code readability improvements. I read through the source code because I intend to present Grace to my team and implement it in some projects we're working on at the moment as a replacement to Microsoft's DI container.

If the pull request does not add any value to the project, feel free to reject it.

ipjohnson commented 1 year ago

Thank you for the PR, I'm going to take a little time to digest it but I'll merge it in the coming days.

bogdandynamic commented 1 year ago

@ipjohnson, thank you writing such a great functionality.

ipjohnson commented 1 year ago

Thank you for the kind words. This lgtm, I'll merge on saturday and put out a new RC package.