ipjohnson / Grace

Grace is a feature rich dependency injection container library
MIT License
337 stars 33 forks source link

Strong name signing assemblies? #70

Closed RandomEngy closed 7 years ago

RandomEngy commented 7 years ago

We want our project to output strong named assemblies, but to do that all our references need to be strong-named as well. Can you strong-name sign the Grace assemblies? The documentation says you could even check in the private key in source control if you wanted.

ipjohnson commented 7 years ago

Hi Random

After reading up a little bit I think it should be pretty easy for me to sign it and get it into the build. I'll make the change in the next day or two and push a Beta build (probably 5.2.0-Beta*) to nuget for some testing.

-Ian

RandomEngy commented 7 years ago

Thanks!

ipjohnson commented 7 years ago

Ok so I've signed Grace and all the Grace. assemblies and pushed beta versions to nuget (5.2.0-Beta).

Give it a whirl and let me know. I'll probably look to do a release in the next week.

RandomEngy commented 7 years ago

Works great, thanks!

ipjohnson commented 7 years ago

I've released version 6.0.0 that's signed (decided it made sense to up major version).