ipkn / crow

Crow is very fast and easy to use C++ micro web framework (inspired by Python Flask)
BSD 3-Clause "New" or "Revised" License
7.46k stars 889 forks source link

Cannot build on boost 1.70 #340

Open mattn opened 5 years ago

mattn commented 5 years ago
g++ -std=c++14 -c -I../include -I. helloworld.cpp -o helloworld.o

In file included from ../include/crow.h:7,
                 from helloworld.cpp:1:
../include/crow/socket_adaptors.h: In member function 'boost::asio::io_service& crow::SocketAdaptor::get_io_service()':
../include/crow/socket_adaptors.h:22:28: error: 'boost::asio::ip::tcp::socket' {aka 'class boost::asio::basic_stream_socket<boost::asio::ip::tcp>'} has no member named 'get_io_service'
             return socket_.get_io_service();
                            ^~~~~~~~~~~~~~
../include/crow/app.h:63: confused by earlier errors, bailing out

mingw32-make: *** [Makefile:24: helloworld.o] Error 1
moneroexamples commented 5 years ago

In one of my project's that uses crow, the issue was fixed. Can check here: https://github.com/moneroexamples/onion-monero-blockchain-explorer/commit/76a0efa8ee3ea5bb466b81d84357d2fd76920cbd

mattn commented 5 years ago

I confirmed the patch fixes this issue. Thank you.

mattn commented 5 years ago

Could you please send this patch as pull-request?

moneroexamples commented 5 years ago

No problem. PR submitted, though I don't expect it being ever merged. The crow project is pretty much dead at this point.

pfeatherstone commented 4 years ago

No problem. PR submitted, though I don't expect it being ever merged. The crow project is pretty much dead at this point.

Maybe this repo should be maintained on a fork??

mrozigor commented 4 years ago

I tried, but have no time to create new things right now. But if you want, you can contribute to my fork and then I'll merge changes ;)