[fix] Make signal handler optional

ipkn / crow

Crow is very fast and easy to use C++ micro web framework (inspired by Python Flask)

BSD 3-Clause "New" or "Revised" License

7.43k stars 889 forks source link

Closed NRizzoInc closed 3 years ago

NRizzoInc commented 3 years ago

closes #251
crow app has a built in signal handler which may interfere with another signal handler
solution: add ability to remove crow's handlers, and to add them back
credit: @ilejn (I just put up a pr for his suggested patch)

edit:

to remove: app.signal_clear().port(<port>).multithreaded().run() to add back: app.signal_add(int signal_number)

The-EDev commented 3 years ago

Hi, First off thanks for bringing this up. But unfortunately this repo hasn't been maintained in almost 3 years.

A few people and I are maintaining a separate version here.

Feel free to open any issues or make this same PR there. However I'll still implement this and run the tests and everything if you choose not to.

NRizzoInc commented 3 years ago

Oh thanks for letting me know! I'll try making a pr over there instead

NRizzoInc commented 3 years ago