search

ipld / js-ipld-block

Implementation of the Block data structure in JavaScript.
MIT License
13 stars 16 forks source link

TypeScript support #55

Closed Xmader closed 4 years ago

Xmader commented 4 years ago

https://github.com/ipfs/js-ipfs/issues/2945

codecov[bot] commented 4 years ago

Codecov Report

Merging #55 into master will increase coverage by 1.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   84.61%   85.71%   +1.09%     
==========================================
  Files           1        1              
  Lines          13       14       +1     
==========================================
+ Hits           11       12       +1     
  Misses          2        2
Impacted Files Coverage Δ
src/index.js 85.71% <100.00%> (+1.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a93204...fa7b49d. Read the comment docs.

rvagg commented 4 years ago

It's probably not a good idea to conflate the withIs issue with TS support, for the sake of keeping things manageable and letting @Xmader actually make meaningful progress. I think we should just accept this change as a chunk, and file an issue stating a desire to move away from withIs, although I'm not as concerned with it living here since we're moving away from this abstraction anyway (see js-block and js-multiformats) so this is previous-generation work.

vmx commented 4 years ago

Thanks everyone involved for this change and helping with the review.