search

ipld / js-ipld-git

MIT License
34 stars 11 forks source link

chore: change from callbacks to promises #38

Closed reconbot closed 5 years ago

reconbot commented 5 years ago

Works https://github.com/ipfs/js-ipfs/issues/1670

vmx commented 5 years ago

Thanks @reconbot for your contribution! I sadly can't merge this right away, as the IPLD project is taking the change of also making other API changes to the format. https://github.com/ipld/interface-ipld-format/pull/50 contains more information about those.

My plan is to get the top-level API working first (https://github.com/ipld/js-ipld/pull/185) and then updates all those formats. That will be a lot of work and any help will be appreciated once we get there.

I'll do a proper review of this PR, once I know what changes will exactly be needed (I'll port ipld-dag-pb first.

Sorry for not communicating this more clearly earlier.

reconbot commented 5 years ago

Yeah no worries, looks like I should close this in the meantime. =)

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c370777). Click here to learn what that means. The diff coverage is 84.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage          ?   93.68%           
=========================================
  Files             ?        7           
  Lines             ?      285           
  Branches          ?        0           
=========================================
  Hits              ?      267           
  Misses            ?       18           
  Partials          ?        0
Impacted Files Coverage Δ
src/util/commit.js 95.89% <62.5%> (ø)
src/util/tree.js 93.93% <71.42%> (ø)
src/util.js 89.74% <78.94%> (ø)
src/util/tag.js 95.23% <80%> (ø)
src/resolver.js 93.1% <92.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c370777...5a46136. Read the comment docs.

reconbot commented 5 years ago

Just reread your comment, I'll keep this open for you =)

vmx commented 5 years ago

This is superseded by https://github.com/ipld/js-ipld-git/pull/51. Though thanks for your contribution @reconbot!