achingbrain commented 4 years ago

Since https://github.com/multiformats/js-multihash/pull/76 was released the multihashes module does not export default hash lengths any more.

For reasons that are not clear it went out as a patch release which means ipld-git is currently broken.

This PR hard codes the hash length as it is known, and also removes the multihashes dep as we can use the one exported from multihashing-async.

Ref: https://github.com/multiformats/js-multihash/pull/76#issuecomment-646561123

codecov[bot] commented 4 years ago

Codecov Report

Merging #67 into master will decrease coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   84.55%   84.49%   -0.06%     
==========================================
  Files           7        7              
  Lines         259      258       -1     
==========================================
- Hits          219      218       -1     
  Misses         40       40

Impacted Files	Coverage Δ
src/util/util.js	`92.10% <100.00%> (-0.21%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5f2209...caf6eb0. Read the comment docs.

vmx commented 4 years ago

Thanks a lot @achingbrain.

ipld / js-ipld-git

fix: multihashes does not export default lengths any more #67

Codecov Report