ipld / js-ipld

The JavaScript Implementation of IPLD
https://ipld.io
MIT License
119 stars 37 forks source link

Can we get a new release soon and update js-ipld on js-ipfs? #116

Closed daviddias closed 6 years ago

daviddias commented 6 years ago

Is this possible, @vmx? For the js-ipfs 0.28 release?

vmx commented 6 years ago

@diasdavid Feel free to do a release (or if you want, I can also do the release). It would be under the current name js-ipld-resolver. Let's target proper naming and description (https://github.com/ipld/js-ipld/issues/112) for the next release.

daviddias commented 6 years ago

@vmx why not deprecate the old name and release with the new name?

vmx commented 6 years ago

@diasdavid: If we can sort out #112 that's fine for me.

daviddias commented 6 years ago

@vmx I believe you have everything you need from https://github.com/ipld/js-ipld/issues/112#issuecomment-367770576

vmx commented 6 years ago

@diasdavid So I should just change the package name name and publish a 0.28 under the new name?

daviddias commented 6 years ago

@vmx exactly and then deprecate ipld-resolver with the message to use just ipld.

daviddias commented 6 years ago

And of course, updating it in js-ipfs-unixfs-engine and js-ipfs too :)

vmx commented 6 years ago

I don't know if there's any guidelines for deprecation messages. What a about using this one:

WARNING: This project has been renamed to "ipld". Install using "ipld" instead.

vmx commented 6 years ago

Sorry, I should've closed #93 and not this one. This one needs more work (and code changes on other packages).

vmx commented 6 years ago

@diasdavid The js-ipfs-unixfs-engine update will take a bit as currently some tests fail: https://github.com/ipfs/js-ipfs-unixfs-engine/issues/203

daviddias commented 6 years ago

thanks @vmx, just incorporated your fixes, updated deps and released js-ipfs-unixfs-engine \o/

vmx commented 6 years ago

Almost there https://github.com/ipfs/js-ipfs-unixfs-engine/pull/206

daviddias commented 6 years ago

got it. Confused with the refactor on js-ipfs which I also merged :) Thanks for being on top of things!

vmx commented 6 years ago

@diasdavid If you do another js-ipfs-unixfs-engine release, I think we are ready to go from an js-ipld perspective. One there's a new release of js-ipfs I'll deprecate js-ipld-resolver.

vmx commented 6 years ago

All packages that depended on ipld-resolver (https://github.com/ipfs/js-ipfs, https://github.com/ipfs/js-ipfs-unixfs-engine) switched to just "ipld". I will close this issue when I deprecated js-ipld-resolver, which I will do once https://github.com/ipfs/js-ipfs is releases. Else people will get deprecation messages during installation.

vmx commented 6 years ago

I can't deprecate ipld-resolver:

$ npm deprecate ipld-resolver@'<= 0.14.1' 'WARNING: This project has been renamed to "ipld". Install using "ipld" instead.'
npm ERR! code E422
npm ERR! Unprocessable Entity : ipld-resolver

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/vmx/.npm/_logs/2018-03-02T13_06_01_826Z-debug.log
daviddias commented 6 years ago

@vmx have you reached out to npm support?

vmx commented 6 years ago

@diasdavid No I haven't, I thought I'm doing something wrong.

daviddias commented 6 years ago

@vmx have you tried just with npm deprecate ipld-resolver@0.14.1?

vmx commented 6 years ago

@diasdavid Yes, also without version and putting the quotes around the name and version.