achingbrain commented 4 years ago

This is so the user can signal that they are no longer interested in the results of the operation and system components can stop trying to fulfil it.

achingbrain commented 4 years ago

Refs ipfs/js-ipfs#2884

codecov[bot] commented 4 years ago

Codecov Report

Merging #267 into master will increase coverage by 3.28%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   86.84%   90.13%   +3.28%     
==========================================
  Files           2        2              
  Lines         152      152              
==========================================
+ Hits          132      137       +5     
+ Misses         20       15       -5

Impacted Files	Coverage Δ
src/index.js	`88.97% <100.00%> (+3.67%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee554e7...6488b8a. Read the comment docs.

vmx commented 4 years ago

The test failure seems to be an actual one. I can reproduce it locally even with a 30s timeout. I did run it locally with:

npm run test -- --target=browser --timeout=30000 -- --browsers FirefoxHeadless

It doesn't happen all the time, but almost on every run I do.

@achingbrain can you please have a look?

achingbrain commented 4 years ago

Looks better now. Did you force-push just to trigger a build? Cos you can do that from the Travis CI without changing public history..

vmx commented 4 years ago

I force-pushed because I did a rebase.

ipld / js-ipld

feat: support passing AbortSignal instances to the configured blockservice #267

Codecov Report