search

ipld / js-unixfs

UnixFS Directed Acyclic Graph for IPLD
Other
7 stars 4 forks source link

Remove dependency on protobufjs #31

Open Gozala opened 2 years ago

Gozala commented 2 years ago

From the private thread discussing the issue

protobufjs is big, complex, uses eval and has circular dependencies

image

Seem like there is even viable alternatives out there https://github.com/timostamm/protobuf-ts

Ideally we won't even pull in the peps here and go with approach @rvagg did in https://github.com/ipld/js-dag-pb/blob/master/src/pb-encode.js

talentlessguy commented 1 year ago

ETA on this? or it's low priority

tsemachh commented 1 year ago

I am also looking into it , we can't use it in chrome extension as it requires manifest V3 which forbids eval usage

tuler commented 4 months ago

Also it brings ~4.9mb to the install size.

Gozala commented 4 months ago

There is no ETA or anyone actually working on it, if someone wants to take a stab at it I'd be happy to help, but I don't have cycles to do the work myself.

ikreymer commented 4 months ago

We might have to drop IPFS support in ArchiveWeb.page extension temporarily until this is resolved, since this is blocking the move to MV3 :( (with MV2 deprecation starting next week)

Edit: Still investigating, may be less of an issue after updating to latest @ipld/unifx

We can help test this as well in our extension, but otherwise fairly time constrained as well

tsemachh commented 4 months ago

I would patch it as PR is still pending from some reason see: https://github.com/protobufjs/protobuf.js/pull/1941