search

ipld / py-cid

Self-describing content-addressed identifiers for distributed systems implementation in Python
MIT License
36 stars 19 forks source link

Use base32 encoding for CIDv1 #33

Closed veqtor closed 2 years ago

veqtor commented 2 years ago

CIDv1 should use base32 encoding by default

rvagg commented 2 years ago

@dhruvbaldawa are you still able/interested in helping maintaining this library? Can you help review & get this over the line. We're defaulting to base32 CIDs in most places now where possible so this seems like a positive change.

BigLep commented 2 years ago

2022-08-23 conversation: we need to find a maintainer for this repo.

rvagg commented 2 years ago

this does need test updates to match, @veqtor are you able to take a look at the tests and get them passing (see Travis too):

    def test_encode_default(self, cid):
        """ #encode defaults to base58btc encoding """
>       assert cid.encode() == b'zdj7WhuEjrB52m1BisYCtmjH1hSKa7yZ3jEZ9JcXaFRD51wVz'
E       AssertionError: assert b'bafybeifzju...eei66wof36n5e' == b'zdj7WhuEjrB5...9JcXaFRD51wVz'
E         At index 0 diff: 98 != 122
E         Left contains 10 more items, first extra item: 54
E         Use -v to get the full diff
anorth commented 2 years ago

Change looks good to me (after tests)

BigLep commented 2 years ago

Per https://github.com/ipld/py-cid/blob/master/README.rst, this repo is not maintained and has been archived.

If someone would like to fork it and support it, IPLD stewards are happy to point to a supported fork. Please open an issue in ipld/ipld requesting this or ask in #ipld in IPFS Discord, Matrix, or FIL Slack.

rvagg commented 2 years ago

repo is being (re)archived