search

ipld / rust-ipld-core

This crate provides core types for interoperating with IPLD.
Apache License 2.0
5 stars 4 forks source link

fix: introduce `codec` feature flag #14

Closed vmx closed 5 months ago

vmx commented 5 months ago

The Link trait needs at least Rust version 1.75. This commit introduces a codec feature flag, so that lower versions of Rust can be supported, in case no Codec trait implementation is needed.

Fixes #13.

@Stebalien This needs a new minor release (once merged) as it could technically break things for people that use default-features = false, right?

Stebalien commented 5 months ago

Yeah, this probably requires a new minor release.

rvagg commented 5 months ago

do these need docs since there's extra hoops to jump through here to use the feature?

Stebalien commented 5 months ago

do these need docs since there's extra hoops to jump through here to use the feature?

The feature is enabled by default. But it would be good to have additional docs describing how to reduce the MSRV.

vmx commented 5 months ago

I've added some more docs. Please re-approve.