search

ipld / specs

Content-addressed, authenticated, immutable data structures
Other
592 stars 108 forks source link

Feat: Move metadata to core protocol #213

Closed hannahhoward closed 4 years ago

hannahhoward commented 5 years ago

Goals

Just a follow-up to #205 -- @Stebalien made the valid point that response metadata is actually necessary to protect against DOS vectors from a malicious responder, and therefore should not be an optional extension. This makes sense especially given go-graphsync implements metadata as part of its protocol already.

Implementation

Move metadata into core protobuf, not an extension (I don't want get into required vs optional extensions for now -- all extensions are optional and are not required to be supported in the protocol ATM)

mikeal commented 4 years ago

Closing for now based on Hannah’s last comment.