search

ipld / specs

Content-addressed, authenticated, immutable data structures
Other
592 stars 108 forks source link

dag-pb: express as IPLD Schema #247

Closed rvagg closed 4 years ago

rvagg commented 4 years ago

Fixes: #245

While I have it open, may as well push something for this. Feel free to edit directly if you have opinions.

rvagg commented 4 years ago

reaching the limits of my protobof knowledge, @vmx are you any deeper on this stuff?

warpfork commented 4 years ago

I pushed another commit to the branch with a little more prose. It added section headers to separate description of the serial format and the logical format into their own topics. While I had it open, I also poked at the introduction of the Pathing section a bit, to try clarify that it's one of several mechanisms, and nonstandard compared to other parts of IPLD.

@rvagg you may want to take a look at that and make sure I didn't make a complete mess of it.

rvagg commented 4 years ago

I've pushed some edits here: took away optional on the Hash and made the names start with uppercase characters. I think I'm synthesizing the conversation here so far but please take a look and let me know if you're unhappy with the state, otherwise I'll assume silence as agreement.

vmx commented 4 years ago

@rvagg sorry for screwing up this PR's log. I thought I merge master into it and things will be fine. Somehow there was still a conflict. So I ended pushing a proper rebase, hence the force push. I just updated it to use DAG-PB instead of DagPB to be consistent.

This PR has been open for long and I haven't seen any objections, so I think it's good to go.