proposal: specify hash algorithm by integer code in hashmap

ipld / specs

Content-addressed, authenticated, immutable data structures

Other

592 stars 108 forks source link

proposal: specify hash algorithm by integer code in hashmap #277

Closed mikeal closed 4 years ago

mikeal commented 4 years ago

This might be worth doing since we’ve been trying to move away from string identifiers for multiformats. It’s also a little more compact when serialized.

rvagg commented 4 years ago

Line 138 should probably be updated to say "code" rather than "identifier", other than that I guess this is OK.

mvdan commented 4 years ago

We discussed this on Slack a couple of weeks ago and agreed it's a good idea. Should we just apply Rod's suggestion and merge? I think GitHub nowadays allows maintainers to edit PRs directly.

rvagg commented 4 years ago

Line 138 should probably be updated to say "code" rather than "identifier", other than that I guess this is OK.

that still stands @mikeal, the text needs to be changed to match