search

ipld / specs

Content-addressed, authenticated, immutable data structures
Other
592 stars 108 forks source link

feat: support filecoin hamt in same schema #338

Closed mikeal closed 3 years ago

mikeal commented 3 years ago

This is an attempt to support the Filecoin HAMT in the same schema. We should discuss the implications of this in the IPLD call because I’m not sure how well a double union will work in practice.

mikeal commented 3 years ago

@rvagg @mvdan where did we land with this? Did this end up working for the new Go implementation of did we find some other reason we can’t make the schemas compatible?

willscott commented 3 years ago

i believe they are compatible for the forthcoming actor hamts in spec-actors v3

mvdan commented 3 years ago

Yes, luckily their v3 now uses a kinded union for their equivalent to our Element :)

Something like what you did here would be useful if we want to support filecoin HAMTs older than v3 with our ADL, but as far as I know that's not planned right now. So I think we should close this PR for the time being, without losing the diff in case we want to dig it up later.