django 1.9 and up compatibility for `LoggedOutMixin`

[grucha]

From django 1.9 onwards the permission_denied view takes mandatory second positiopnal argument (exception).

Try going to password reset view (or any view based on LoggedOutMixin) while you're logged in - you'll get a TypeError instead of a 403 response.

[mpasternak]

Thank you very much for this insightful contribution. The only one thing that is missing is a failing test. Could you please add one?

[grucha]

Ok, will do.

[fundacjafanimani]

o co chodzi? :)

27.01.2018 12:05 PM "grucha" notifications@github.com napisał(a):

Ok, will do.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iplweb/django-password-policies-iplweb/pull/1#issuecomment-360980474, or mute the thread https://github.com/notifications/unsubscribe-auth/ANW39Tep_5DIWUYK95IAkI7SLqzaHlm2ks5tOxEIgaJpZM4RtgnW .

[dnsl48]

Wouldn't it be better to check from django import VERSION than catching a TypeError?

[mpasternak]

Patches accepted

Wysłane z iPada

Wiadomość napisana przez dnsl48 notifications@github.com w dniu 28.03.2018, o godz. 22:25:

Wouldn't it be better to check from django import VERSION than catching a TypeError?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[mberkman-psh]

Are you going to merge this?

[mpasternak]

Of course. As soon as I get a patch with a failing test. I think I stated this in my first comment in 2018 here https://github.com/iplweb/django-password-policies-iplweb/pull/1#issuecomment-360615064

[mberkman-psh]

Do you have an ETA?

[mpasternak]

No, but you can submit a pull request!

[mpasternak]

Django 1.9 is pretty old ATM and the test patch I requested never came. Closing!