search

ipmitool / test

0 stars 0 forks source link

ekanalyzer doesn't check FRU checksums on 'frushow' #48

Open AlexanderAmelkin opened 10 years ago

AlexanderAmelkin commented 10 years ago

Reported by: Alexander Amelkin Original Ticket: ipmitool/bugs/321

The 'ekanalyzer frushow' command never reports correctness of the FRU checksums. It does so neither for the FRU header, nor for FRU info areas. It does display the checksum value (as stored in the FRU file), but never checks if it matches the actual data.

AlexanderAmelkin commented 10 years ago

Original comment by: Zdenek Styblik

AlexanderAmelkin commented 8 years ago

I have a checksum function handy for this. IMHO, it makes sense to verify the checksum.

Original comment by: Hinko Kocevar

AlexanderAmelkin commented 8 years ago

Do you mean as an external script?

Original comment by: Zdenek Styblik

AlexanderAmelkin commented 8 years ago

As a C function. IMHO, checksum should be checked before fields are parsed/decoded.

Original comment by: Hinko Kocevar

AlexanderAmelkin commented 8 years ago

I'd say that fields must be decoded anyway. But an indication of wrong checksum is desirable. Way too many FRUs out there with valid data but with incorrect checksums. Blindly discarding them if the checksum is wrong would be a disaster.

Original comment by: Alexander Amelkin