search

ipmitool / test

0 stars 0 forks source link

ipmi_chassis.c bootdev help mistake #50

Open AlexanderAmelkin opened 10 years ago

AlexanderAmelkin commented 10 years ago

Reported by: Konstantin Original Ticket: ipmitool/bugs/338

ipmitool chassis bootdev none options=help Legal options are: /----/ cons_redirect=default: Console redirection occurs per BIOS configuration setting cons_redirect=skip: Suppress (skip) console redirection if enabled cons_redirect=enable: Suppress (skip) console redirection if enabled

File: /lib/ipmi_chassis.c:1338

{"cons_redirect=skip", 2, (3<<0), (1<<0), "Suppress (skip) console redirection if enabled"}, {"cons_redirect=enable", 2, (3<<0), (2<<0), "Suppress (skip) console redirection if enabled"}, This is what in the help output is shown.

ipmi_chassis.c:685 switch( ((rsp->data[4]>>0)&0x03)) { case 0: printf("Console redirection occurs per BIOS configuration setting (default)\n"); break; case 1: printf("Suppress (skip) console redirection if enabled\n"); break; case 2: printf("Request console redirection be enabled\n"); break; default: printf("Flag error\n"); break; } And this is possibly intended to be shown. So i think that the information from case 2 should be placed in "cons_redirect=enable" option description

AlexanderAmelkin commented 9 years ago

Original comment by: Zdenek Styblik