ipni / specs

:book: Technical Specification of IPNI Protocols
11 stars 2 forks source link

Document IPNI HTTP provider specification #18

Closed masih closed 1 year ago

masih commented 1 year ago

Rendered

Note: I have opted for least disruptive spec relative to the current implementation. If you folks think this doesn't matter as much there are things that I'd like to change.

Fixes #16

rvagg commented 1 year ago

It might be nice to leave open (and document here) the ability of announcement Addrs to include optional httpath specifier, and be clear how this interacts with the new path prefixes defined here. If I provide an httpath in a multiaddr, does it override /ipni/v1/ad/, or does it prepend to this? My own limited use of this has involved wanting to change the default provider server that responds to /head and /{cid} to one that responds on /_ipni/head and /_ipni/{cid} because I want to reuse an existing server that has other things going on at the root. So I like that this is now namespaced; I also like optionality, but it's not critical now that this is so specific. i.e. custom httpath could be ruled out in this spec and I wouldn't be too upset, but I'd like the clarity.

masih commented 1 year ago

@rvagg thank you for pointing httpath out. I have added a Namespacing section to spell out how I think the extra paths are to be handled here.

Can I ask you to give it a read and let me know what you think please?

Also captured https://github.com/ipni/go-libipni/issues/42

rvagg commented 1 year ago

great! I've followed up in https://github.com/ipni/go-libipni/issues/42

masih commented 1 year ago

Cc @lidel @aschmahmann

BigLep commented 1 year ago

Doh - my original comment was in the wrong issue - my bad!