Investigate consistency of calls to `StorageWriteOpener` and `IncomingBlockHook` - Githubissues

ipni / storetheindex

A directory of CIDs

Other

78 stars 22 forks source link

Investigate consistency of calls to `StorageWriteOpener` and `IncomingBlockHook` #175

Closed masih closed 2 years ago

masih commented 2 years ago

The advertisement entry processing logic is spread across two components:

StorageWriteOpener , and
storageHook

Considering the above;

Is it possible for one to be called but for the other to not be called? For example, if a cid is already present in the datastore/linksystem but synced over graphsync. Or if a component returns err.
If so, would the processing logic continue to work correctly when that happens?

Consider moving as much of the logic to one place as possible to avoid this kind of edge cases.

gammazero commented 2 years ago

Investigated by @MarcoPolo and resolved by #180