ipni / storetheindex

A directory of CIDs
Other
79 stars 22 forks source link

feat: make public the ingest and registry #2680

Open alanshaw opened 1 month ago

alanshaw commented 1 month ago

Context

I wanted to run an IPNI node locally, programmatically, for testing.

Proposed Changes

Make ingest and registry packages public.

Tests

No code added.

Revert Strategy

Change is safe to revert.

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.69%. Comparing base (f74cf2a) to head (11216d0). Report is 67 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2680 +/- ## ========================================== + Coverage 42.85% 45.69% +2.84% ========================================== Files 96 94 -2 Lines 11436 11186 -250 ========================================== + Hits 4901 5112 +211 + Misses 5936 5462 -474 - Partials 599 612 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gammazero commented 1 month ago

@masih, @alanshaw storetheindex is meant to be an application and not a library. I recommend that the ingestion/registry code be moved into another repo that is meant as a library, so that it can be maintained as such and not treated like an application for our own use.

I think the code should either move into ipni/go-libipni or into another new repo ipni/ingest