ipno-llead / processing

Processing repo for the Innocence Project New Orleans' Louisiana Law Enforcement Accountability Database
7 stars 5 forks source link

Copied the work from the fork repo to the original repo in order to u… #506

Closed hungEA closed 1 year ago

hungEA commented 1 year ago

Title: 248 - Develop data validator

Description:

The data-validator program will be able to run validation check for the required csv files that would be push to WRGL before being imported to BE database. The process will be applied to the following data

baoea commented 1 year ago

Hi @ayyubibrahimi. Could you explain us why this process fails? We need to pass this step to test our validator. Thanks!

ayyubibrahimi commented 1 year ago

I'll review.

ayyubibrahimi commented 1 year ago

I can't re-produce this error on my local. It's a weird one. Can you pull the latest merge from main and re-push this branch?

ayyubibrahimi commented 1 year ago

I will re-write this function.

ayyubibrahimi commented 1 year ago

These bugs are weird. I can't reproduce them on my local when I run make, make ran fine with the process-data step for my last PR (the PR that you just merged into this branch), and no arguments are being passed to the similarity function. Can you please advise @pckhoi.

hungEA commented 1 year ago

@ayyubibrahimi @pckhoi our data-validator processes have successfully passed. However, we are not sure why the commit changes in transaction step failed as we did not touch this section at all. Can you have a look please?

ayyubibrahimi commented 1 year ago

Awesome. From what I understand this is a issue with the server connection. Please re-run the failed jobs and it should eventually process successfully.

github-actions[bot] commented 1 year ago

Review data changes at tx/1c79a5c4-ca43-4b7e-99e2-a3b525b7963d

When this PR is merged, this transaction will be applied.

github-actions[bot] commented 1 year ago

Transaction tx/1c79a5c4-ca43-4b7e-99e2-a3b525b7963d applied.