search

ipodtouch0218 / NSMB-MarioVsLuigi

Standalone Unity remake of New Super Mario Bros DS' multiplayer gamemode, "Mario vs Luigi"
https://ipodtouch0218.itch.io/nsmb-mariovsluigi
662 stars 294 forks source link

Suggestion: In-Game Join/Leave room notifications #136

Open MichaelTheAvali opened 2 years ago

MichaelTheAvali commented 2 years ago

I tend to play solo when no one joins my lobby, but I always have to keep ending the match early just to check if someone's joined, so maybe make it so it alerts you when your playing solo if someone joins the lobby so I don't have to constantly check

SLG64 commented 2 years ago

I like this idea. It could say "(PlayerUsername) joined the party."

SLG64 commented 2 years ago

And maybe the sound is a simple jingle. I got a couple:

/home/chronos/u-639649e1e209099531d3e0784a1230b204c9b951/MyFiles/Downloads/Sm3dl_unused_mario_jingle.ogg.mp3 /home/chronos/u-639649e1e209099531d3e0784a1230b204c9b951/MyFiles/Downloads/SM64DS-high_score.ogg.mp3

ipodtouch0218 commented 1 year ago

Are you talking about actively playing a game, but with only 1 player in the lobby? Like not in the room menu? A "player joined the room" and "player left the room" feature has been planned for a while, just haven't gotten a chance to start on it yet.

@SLG64 And maybe the sound is a simple jingle. I got a couple: Those are files on your machine. We can't see them.

SLG64 commented 1 year ago

Oops, my bad.

MichaelTheAvali commented 1 year ago

Are you talking about actively playing a game, but with only 1 player in the lobby? Like not in the room menu? A "player joined the room" and "player left the room" feature has been planned for a while, just haven't gotten a chance to start on it yet.

Yeah, its just cause I like to play the game solo at times instead of sitting and waiting at the lobby screen for someone to join

drok28 commented 1 year ago

Yeah, I do that too.

SLG64 commented 1 year ago

What I was trying to put in was an unused jingle for SM3DL, which I got from the TCRF.

SLG64 commented 1 year ago

I just realized I can just send a link to the file. My bad! Anyways here it is:

https://tcrf.net/images/transcoded/3/3c/Sm3dl_unused_mario_jingle.ogg/Sm3dl_unused_mario_jingle.ogg.mp3

ipodtouch0218 commented 1 year ago

I just realized I can just send a link to the file. My bad! Anyways here it is:

https://tcrf.net/images/transcoded/3/3c/Sm3dl_unused_mario_jingle.ogg/Sm3dl_unused_mario_jingle.ogg.mp3

Doesn't really fit as a "player joining sound" imo. It'd probably be best to just use the existing "player join" and "player leave" sounds from the minigame mode. Mostly because they already have the same meaning.

SLG64 commented 1 year ago

Oh, that's alright.