Refactor/cp admin user handler

ipol-journal / ipolDevel

IPOL demo system development

GNU Affero General Public License v3.0

23 stars 3 forks source link

Refactor/cp admin user handler #172

Closed hmaciasc closed 1 year ago

hmaciasc commented 1 year ago

This refactor tries to solve all problems regarding CP editor's data to be replicated at demoinfo. Cases tested:

New editor
Delete editor
Editor email modification to an email which is not on demoinfo
Editor email modification to an email which is on demoinfo
Abort add email to editor when an email is in use

If an editor is in demoinfo but not on CP, it will cause problems when trying to add it on CP and will need our attention if that ever happens.

hmaciasc commented 1 year ago

Also: is it OK that's warning and not an error when logging?

Only should happen when an email is in use, I don't think that is an error but has the same effect

I have pushed changes to the branch but the PR is not updating or showing them as part of the PR, any idea why that is happening? I know today github had problems and some downtime

mcolom commented 1 year ago

Only should happen when an email is in use, I don't think that is an error but has the same effect OK!

I have pushed changes to the branch but the PR is not updating or showing them as part of the PR, any idea why that is happening? I know today github had problems and some downtime I don't know, but I can see your commits before and after the review request. Nothing to worry about :)