ipol-journal / ipolDevel

IPOL demo system development
GNU Affero General Public License v3.0
23 stars 3 forks source link

Access to 3D archive not available #189

Open kerautret opened 1 year ago

kerautret commented 1 year ago

Hi IPOL teams, I detected that the access to the 3D view from the archive page is failing. I am not sure if it is related to the last contact of the main 3D view. If you want to test it on a published demo you can do:

I detect it since I am going to submit the revised version of an ipol paper and in general the editors check such types of demo behavior. So if you have any idea of the problem. Thanks a lot in all cases for your excellent works ! 👏🏻

hmaciasc commented 1 year ago

Hello there!

There was slight a change in the backend side of IPOL a while back and your demo has a request to an endpoint which no longer exists.

extras.js I believe, Line 43:const url = /api/archive/get_experiment?experiment_id=${experiment_id};

"get_experiment" was renamed to "experiment" and now must be a get request, not a post, so if you change your code to look like this the experiment would finally appear. IE: const url = /api/archive/experiment/${experiment_id};

Hope this helps, let us know if it does work after that so that I can close the issue :)

kerautret commented 1 year ago

Thanks @hmaciasc I just tried with the change of line 43 and it looks the same results ;(

hmaciasc commented 1 year ago

We also don't use status OK/KO anymore, please rely on http status codes. L.46: if (data.status === "OK") {

kerautret commented 1 year ago

I remove the if and it looks to advance since it give the error related access from origin (if I am not wrong): Capture d’écran 2023-09-06 à 13 07 16

hmaciasc commented 1 year ago

The URL of the resultMerge.obj is wrong somehow, should be something like this: https://ipolcore.ipol.im/api/core/shared_folder/run/418/{KEY}/resultMerge.obj

Instead you have: https://ipolcore.ipol.im/api/core/shared_folder/run/workdir.exec/resultMerge.obj

About the CORS we're trying to fix it.

kerautret commented 1 year ago

thanks but it is well the first you mention that is line 69:

  return `https://3dviewer.net#https://ipolcore.ipol.im/api/core/shared_folder/run/${demo_id}/${key}/resultMerge.obj`;

🤔

kerautret commented 1 year ago

I really wonder where come this "worksdir.exec" I don't see it in extra.js nor in source script ..

hmaciasc commented 1 year ago

image It is in the execution -> algo_info that comes back from "getArchiveURL", I'm not sure if your demos is populating that or what you're doing with it but that is the origin I see.

kerautret commented 1 year ago

In algo_info it is the original url including $id that is perhaps empty but this field is replaced by extra.js

Perhaps the error comes more from the change on /api/archive/experiment/${experiment_id} since I see this errors Capture d’écran 2023-09-07 à 15 30 44

The debug is not easy since I just see that the update of the extra.js is not direct (perhaps due to navigator cache processing)

kerautret commented 1 year ago

Else we could perhaps have a look with @mcolom tomorrow at the workshop on replicability in Paris ;)

mcolom commented 1 year ago

Else we could perhaps have a look with @mcolom tomorrow at the workshop on replicability in Paris ;)

@kerautret Sure we can!

kidanger commented 11 months ago

Hello Bertrand, We decided to integrate the 3dviewer as a new output type ("3d"). It will solve this issue and many in the future. Best

kerautret commented 11 months ago

Hi Jérémy, Very nice new features thanks ! ;) By the way it could be nice if the concept is also able it handle the type of 3d volumetric results. We plane to submit work using medical images like the following test : https://ipolcore.ipol.im/demo/clientApp/demo.html?id=5555531082028 It works in the same way than the 3D mesh, juste the url of the javascript viewer is different and the extension is also not the same (.vol, .nii and other 3D ITK format)