search

ippa / jaws

Jaws - HTML5 canvas javascript 2D Game Framework
https://jawsjs.ippa.se
GNU Lesser General Public License v3.0
363 stars 75 forks source link

Replace deprecated deleteIf() calls with removeIf() #40

Closed dmitrizagidulin closed 12 years ago

dmitrizagidulin commented 12 years ago

Minor change - if deleteIf() is to be deprecated, let's remove it from the examples/docs.

(At least it taught me a fun fact, that the Eclipse JS plugin displays deprecated functions with a strikethrough. Took me way too many minutes during Ludum Dare to figure what that was, tho :) )

dmitrizagidulin commented 12 years ago

Apologies - I thought I could do more than one pull request in a row. The edit adds:

Added more JSDoc comments to SpriteList. Tweaked splice() to return the removed elements, per function spec.

ippa commented 12 years ago

Hm, deleteIf() is deprecated? :) .. when this this happen, sounds like a mistake, I use it in almost all my games on ippa.se

dmitrizagidulin commented 12 years ago

Ah, ok. So we should remove the '@deprecated' tag in the jsdoc of deleteIf(), then :) If that was put there by mistake.

ippa commented 12 years ago

so yes, it was rightfully deprecated. git blame blamed it on me so ;). we'll leave it in jaws for a while though.