ipqa-research / yaeos

Thermodynamic Equations of State, Fortran library with both automatic and anallytical derivation capabilities
https://ipqa-research.github.io/yaeos/
Mozilla Public License 2.0
26 stars 4 forks source link

Solving ifort/IFX runtime issues #101

Open fedebenelli opened 1 month ago

fedebenelli commented 1 month ago

When compiling with ifx and ifort there is a problem (at least on my PC, since it seems to work ok over Github CI) when tracing phase envelopes. Where the passed function foo from the pt_envelope_2ph function to the continuation function provides a wrong reference.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.37%. Comparing base (904405a) to head (09a6def).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #101 +/- ## ========================================== - Coverage 93.41% 93.37% -0.04% ========================================== Files 57 57 Lines 2686 2688 +2 Branches 194 194 ========================================== + Hits 2509 2510 +1 - Misses 127 128 +1 Partials 50 50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fedebenelli commented 1 month ago

As it was seen on the optimization API changes, it seems that ifx does not behave well when passing a procedure that was defined inside another procedure

subroutine foo(x, y)
    call hoo(goo, x, y)
contains
    subroutine goo(x, y)
    end subroutine
end subroutine

Maybe there is some kind of relation here