ipqa-research / yaeos

Thermodynamic Equations of State, Fortran library with both automatic and anallytical derivation capabilities
https://ipqa-research.github.io/yaeos/
Mozilla Public License 2.0
27 stars 4 forks source link

Python API work #86

Closed fedebenelli closed 3 months ago

fedebenelli commented 3 months ago

We are in the process of adding a Python API that wraps our library, that it is instalable with pip.

Things I consider needed to merge into dev

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 97.80220% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.04%. Comparing base (9613363) to head (e642bb0).

Files Patch % Lines
src/models/residual_helmholtz/ar_models.f90 97.77% 0 Missing and 1 partial :warning:
src/phase_equilibria/stability.f90 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #86 +/- ## ========================================== - Coverage 92.05% 92.04% -0.01% ========================================== Files 54 54 Lines 2543 2540 -3 Branches 190 190 ========================================== - Hits 2341 2338 -3 Misses 154 154 Partials 48 48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fedebenelli commented 3 months ago

Algo a tener en cuenta es que la API C tiene que luego quedar dentro de la librería misma y no en la subcarpeta de Python. En la subcarpeta de Python debería de haber un solo archivo yaeos_python.f90 tipo:

! yaeos_python.f90
module yaeos_python
    use yaeos_c_interface
end module

Yo me encargo de esto, pero lo dejo asentado acá para no olvidarme