Closed fedebenelli closed 1 month ago
Attention: Patch coverage is 79.10959%
with 61 lines
in your changes missing coverage. Please review.
Project coverage is 92.05%. Comparing base (
73daaf6
) to head (3e2cacf
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a big API overhaul with also some improvements.
This pull request should be considered as yaeos 1.0 since it is a big API breaker and we should adopt semantic versioning https://semver.org/
thermoprops
module is a method ofArModel
. This makes it easier to override specific implementations. Mostly volume solving that was the main concern in this branch, each method could have an specific volume solver.yaeos_math
and it is now it is used to obtain CubicEoS volume roots.TODO:
@SalvadorBrandolin if you have time, could you add two tests?
yaeos__models_ar
)