ipr-cnrs / nftables

Ansible role to manage Nftables rules and packages.
139 stars 42 forks source link

Async does not support check_mode #60

Open dennisse opened 1 year ago

dennisse commented 1 year ago

I'm getting errors when using check_mode.

From https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_async.html

As of Ansible 2.3, async does not support check mode and will fail the task when run in check mode. See Validating tasks: check mode and diff mode on how to skip a task in check mode.

Checking for ansible_check_mode will prevent getting an error when running in check mode.

I made a PR (#57) in january, but I haven't gotten any response there.

plochk commented 1 year ago

Nice work on the PR, just encountered this issue myself.

Dear maintainer (@gardouille ? https://github.com/ipr-cnrs/nftables#author-information, @kravietz ), if correct please merge this small PR asap, it renders check mode unable to run otherwise.