search

iprobedroid / swgoh-arena-tracker

47 stars 189 forks source link

Configurable sleep times #11

Closed hatermater closed 3 years ago

hatermater commented 4 years ago

Hi, Great work! Can you make configurable the times in seconds to wait between each player check and after all players are checked configurable? With your current defaults (2 sec and 3 min) if not provided. For example: WAIT_BETWEEN_PLAYERS = 2 WAIT_AFTER_ALL_PLAYERS = 180

Thanks! BR

iprobedroid commented 4 years ago

adding WAIT_BETWEEN_PLAYERS does not make sense unless you want to set it >2 sec, 2 sec is the rate limit imposed by CG, technically it is not a 2 sec wait, it is just a throttle which does not let to poll the API more frequently than once in 2 sec WAIT_AFTER_ALL_PLAYERS is possible, maybe will do, maybe

hatermater commented 4 years ago

Yes. I mean to be able to increase the WAIT_BETWEEN_PLAYERS (>=2 sec, default 2 or 3 or 5 sec if not set) and increase/decrease WAIT_AFTER_ALL_PLAYERS (>=2 sec, default 180 sec if not set) depending on the situation/configuration

iprobedroid commented 4 years ago

what is the point to have WAIT_BETWEEN_PLAYERS > rate limit?